HDF5 filters (compression) #1644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }; | ||
|
|
||
| template <typename JSON, typename Accessor> | ||
| auto parse_filter_by_id(JSON &filter_config, Accessor &&json_accessor) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
c13d131
to
17e41dd
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
17e41dd
to
23f7be5
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
23f7be5
to
233f020
Compare
franzpoeschel
commented
Oct 25, 2024
| if (parameters.joinedDimension.has_value()) | ||
| { | ||
| error::throwOperationUnsupportedInBackend( | ||
| "ADIOS1", "Joined Arrays currently only supported in ADIOS2"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for filters (e.g. compression) in HDF5.
TODO:
Diff: franzpoeschel/openPMD-api@hdf5-independent-flush-config...hdf5-filters